Re: [PATCH 2/2] apic, x86: Use BIOS settings for IBS and MCEthreshold interrupt LVT offsets

[Cyrill Gorcunov]

On Fri, Oct 08, 2010 at 12:21:15PM +0200, Robert Richter wrote:
> On 08.10.10 05:37:24, Cyrill Gorcunov wrote:
> > On Fri, Oct 8, 2010 at 1:24 PM, Robert Richter <robert.richter@xxxxxxx> wrote:
> > ...
> > >> > +                   } else if (lvt_off != offset) {
> > >>
> > >> Could we put explicit type specificator here? For better readbility.
> > >> ...
> > >
> > > Cyrill,
> > >
> > > Do you mean an explicit type cast here, or something else?
> > >
> > 
> > Yeah, explicit type cast (not a big deal though since at moment
> > of course nothing can fire in this snippet, but I think for future
> > modifications better to have explicit cast).
> 
> Hmm, don't think this is really necessary. As an alternative we could
> make variable offset an int too and then do an explicit cast when
> calling setup_APIC_eilvt().
> 
> But I rather tend to leave it as it is.

Well, I don't insist at all. Lets leave it as is.

  Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/