Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

From: T Dent
Date: Fri Oct 08 2010 - 04:39:42 EST


On 10/8/10, matt mooney <mfmooney@xxxxxxxxx> wrote:
> On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@xxxxxxxxx> wrote:
>> I patch against the next-20101006 tree.
>>
>> The patch series replace use of <module>-objs with <module>-y in the
>> staging directory.
>
> Commit messages are written in the present tense. You happen to be
> using two different tenses within the commit message, which is truly
> odd. And why did you not split apart those atrocious statements with
> the infinite column width?
>
You're right I didn't notice. I just copy-and-paste a lot of commits
and just switch the directory.

> This patch series adds little benefit. As Sam has suggested, a more
> general cleanup would be a better goal, and staging is an area that
> needs extra attention some of which has already been pointed out in
> other emails.

I am going to do a more general clean up. I was just breaking it up
into parts, so that its easier to review and get applied.

> -mfm
>
> --
> GPG-Key: 9AFE00EA
>

Thanks,

Tracey D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/