Re: [PATCH 00/33] Staging: Fixed <module-objs> to <module>-y

From: matt mooney
Date: Fri Oct 08 2010 - 03:16:42 EST


On Thu, Oct 7, 2010 at 6:35 PM, T Dent <tdent48227@xxxxxxxxx> wrote:
> I patch against the next-20101006 tree.
>
> The patch series replace use of <module>-objs with <module>-y in the
> staging directory.

Commit messages are written in the present tense. You happen to be
using two different tenses within the commit message, which is truly
odd. And why did you not split apart those atrocious statements with
the infinite column width?

This patch series adds little benefit. As Sam has suggested, a more
general cleanup would be a better goal, and staging is an area that
needs extra attention some of which has already been pointed out in
other emails.

-mfm

--
GPG-Key: 9AFE00EA
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/