Re: [PATCH 16/18] fs: Make iunique independent of inode_lock

From: Christoph Hellwig
Date: Fri Oct 08 2010 - 03:55:29 EST


> + hlist_bl_for_each_entry(inode, node, &b->head, i_hash) {
> + if (inode->i_ino == ino && inode->i_sb == sb) {

wouldn't it be more natural to test the sb first here?

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/