Re: [PATCH 11/18] fs: Introduce per-bucket inode hash locks

[Dave Chinner]

On Fri, Oct 08, 2010 at 03:33:06AM -0400, Christoph Hellwig wrote:
> On Fri, Oct 08, 2010 at 04:21:25PM +1100, Dave Chinner wrote:
> > From: Nick Piggin <npiggin@xxxxxxx>
> > 
> > Protect the inod hash with a single lock is not scalable.  Convert
> 
> s/inod/inode/
> 
> >  	p = &root->inode_tree.rb_node;
> >  	parent = NULL;
> >  
> > -	if (hlist_unhashed(&inode->i_hash))
> > +	if (hlist_bl_unhashed(&inode->i_hash))
> 
> Maybe introduce an inode_unhashed helper for this check which we're
> doing in quite a lot of places?

Ok, makes sense.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/