Re: [PATCH 1/2] autofs: Only declare function when CONFIG_COMPAT is defined

[Geert Uytterhoeven]

On Fri, Sep 24, 2010 at 15:22, Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> From: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
>
> The patch solves the following warnings message when CONFIG_COMPAT
> is not defined:
>
> fs/autofs/root.c:30: warning: âautofs_root_compat_ioctlâ declared âstaticâ but never defined
>
> Signed-off-by: MÃrton NÃmeth <nm127@xxxxxxxxxxx>
> Cc: "H. Peter Anvin" <hpa@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> ---
> Âfs/autofs/root.c | Â Â2 ++
> Â1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/autofs/root.c b/fs/autofs/root.c
> index 11b1ea7..0c4ca81 100644
> --- a/fs/autofs/root.c
> +++ b/fs/autofs/root.c
> @@ -27,7 +27,9 @@ static int autofs_root_unlink(struct inode *,struct dentry *);
> Âstatic int autofs_root_rmdir(struct inode *,struct dentry *);
> Âstatic int autofs_root_mkdir(struct inode *,struct dentry *,int);
> Âstatic long autofs_root_ioctl(struct file *,unsigned int,unsigned long);
> +#ifdef CONFIG_COMPAT
> Âstatic long autofs_root_compat_ioctl(struct file *,unsigned int,unsigned long);
> +#endif
>
> Âconst struct file_operations autofs_root_operations = {
>    Â.llseek     = generic_file_llseek,

An alternative (and IMHO better) fix would be to move autofs_root_operations[]
and autofs_root_inode_operations[] to the bottom of the file, and get rid of all
the forward declarations.

Gr{oetje,eeting}s,

            Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
             Â Â -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/