Re: resend: [PATCH] amba_pl022: Setup SPI configuration based on spi->mode

[Linus Walleij]

2010/9/13 Kevin Wells <kevin.wells@xxxxxxx>:

> SSP_CR0_MASK_SPH (SPHA) should use bit 7, not bit 6.
> Should be:
>       SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 7);
>
>> +
>>        SSP_WRITE_BITS(chip->cr0, chip_info->clk_freq.scr, SSP_CR0_MASK_SCR,
>> 8);
>>        /* Loopback is available on all versions except PL023 */

That's it!

With this correction it starts working, so
Acked-by/Tested-by/Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>

Please submit the whole patch series with corrections and my tag
so Grant can pick it up, and thanks for doing this because I think
it is a great improvement to the driver!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/