RE: resend: [PATCH] amba_pl022: Setup SPI configuration based onspi->mode

From: Kevin Wells
Date: Mon Sep 13 2010 - 12:59:12 EST


> +       if (spi->mode & SPI_CPOL)
> +               tmp = SSP_CLK_POL_IDLE_HIGH;
> +       else
> +               tmp = SSP_CLK_POL_IDLE_LOW;
> +       SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPO, 6);
> +
> +       if (spi->mode & SPI_CPHA)
> +               tmp = SSP_CLK_SECOND_EDGE;
> +       else
> +               tmp = SSP_CLK_FIRST_EDGE;
> +       SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 6);

SSP_CR0_MASK_SPH (SPHA) should use bit 7, not bit 6.
Should be:
SSP_WRITE_BITS(chip->cr0, tmp, SSP_CR0_MASK_SPH, 7);

> +
>        SSP_WRITE_BITS(chip->cr0, chip_info->clk_freq.scr, SSP_CR0_MASK_SCR,
> 8);
>        /* Loopback is available on all versions except PL023 */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/