Re: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only ifdata is transfered over

[Sergei Shtylyov]

Hello.

Ming Lei wrote:

> >   But why not modify the conditional above all that code, just excluding
> > 'is_dma' from it. This conditional already includes (request->actual ==
> > request->length) check. Please recast this patch.

> The two condition is OR relation, not and, so we can't exclude 'is_dma' simply.

   Yes, we can. You're clearly handling only the DMA case with your added 
check, the PIO case was already handled.

> Anyway, the change is not wrong, right?

   Not wrong, but the check is duplicate.

> thanks,

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/