Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

From: Felipe Balbi
Date: Thu Sep 09 2010 - 02:02:15 EST


On Wed, Sep 08, 2010 at 08:49:08PM -0500, Ming Lei wrote:
2010/9/8 venki kaps <venkiece2005@xxxxxxxxx>:

 To resolve the above issue, we have made "PHY power on" in battery
adc on function
 and "PHY power down" in battery adc off function.

Good news, the temperature is bad value from battery adc if otg phy is power
down. Maybe you only need to power on otg phy before reading battery adc, then
power down otg phy after the reading if no usb calbe is connected with musb
for decreasing power consumption. (I am not familiar with battery adc, just
for your refrerence)

I think you only need the usb3v1 regulator. And it can even be in sleep
mode, it doens't have to be on. What I would suggest is that usb3v1
never to be turned off, only put in sleep mode.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/