Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

From: Ming Lei
Date: Wed Sep 08 2010 - 21:49:24 EST


2010/9/8 venki kaps <venkiece2005@xxxxxxxxx>:

>  To resolve the above issue, we have made "PHY power on" in battery
> adc on function
>  and "PHY power down" in battery adc off function.

Good news, the temperature is bad value from battery adc if otg phy is power
down. Maybe you only need to power on otg phy before reading battery adc, then
power down otg phy after the reading if no usb calbe is connected with musb
for decreasing power consumption. (I am not familiar with battery adc, just
for your refrerence)

Anyway, your issue(reading mistaken temperature) is nothing to do with
twl_4030 otg driver and the patch, we does need to power down otg phy
if no vbus or ID event detected.

--
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/