Re: [PATCH] MMC: move regulator handling closer to core v2

[Linus Walleij]

2010/9/4 Adrian Hunter <adrian.hunter@xxxxxxxxx>:

> One of our contractors had a look at the patch and had this comment:
>
> One comment/question:
> /host/mmci.c in function
> "static int __devexit mmci_remove(struct amba_device *dev)" there is code:
>        if (regulator_is_enabled(host->vcc))
>            regulator_disable(host->vcc);
> should "ret = mmc_regulator_set_ocr(mmc, host->vcc, 0);" be added here?

Good catch!

Since it's in the remove() we can't do much about the return value from that
call but we should sure use the _set_ocr() so fixed it and pushed v3.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/