Re: [PATCH] MMC: move regulator handling closer to core v2

[Adrian Hunter]

Linus Walleij wrote:
> 2010/8/31 Linus Walleij <linus.walleij@xxxxxxxxxxxxxx>:
>
> > After discovering a problem in regulator reference counting I
> > took Mark Brown's advice to move the reference count into the
> > MMC core by making the regulator status a member of
> > struct mmc_host.
>
> This has an Reveiwed-by from the regulator maintainer and
> seems to address all comments, noone is objection so Andrew
> can you pick it up?

One of our contractors had a look at the patch and had this comment:

One comment/question:
/host/mmci.c in function
"static int __devexit mmci_remove(struct amba_device *dev)" there is code:
        if (regulator_is_enabled(host->vcc))
            regulator_disable(host->vcc);
should "ret = mmc_regulator_set_ocr(mmc, host->vcc, 0);" be added here?

> Yours,
> Linus Walleij

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/