Re: [patch 4/6] jbd: remove dependency on __GFP_NOFAIL

From: Andrew Morton
Date: Mon Aug 23 2010 - 15:28:29 EST


On Tue, 17 Aug 2010 11:51:03 +0200
Jan Kara <jack@xxxxxxx> wrote:

> On Mon 16-08-10 19:58:01, David Rientjes wrote:
> > Removes the dependency on __GFP_NOFAIL by looping indefinitely in the
> > caller.
> >
> > The error handling when kzalloc() returns NULL in start_this_handle()
> > was removed since it was unreachable.
> Thanks! I've added the patch to my tree.

Please unadd it. JBD should be fixed so that it can appropriately
handle out-of-memory conditions. Until that time we shouldn't hide its
shortcomings with this open-coded equivalent.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/