Re: [PATCH 05/10] mm: check kmalloc() return value

[Pekka Enberg]

On Wed, Jul 28, 2010 at 7:40 PM, Kulikov Vasiliy <segooon@xxxxxxxxx> wrote:
> kmalloc() may fail, if so return -ENOMEM.
>
> Signed-off-by: Kulikov Vasiliy <segooon@xxxxxxxxx>

Acked-by: Pekka Enberg <penberg@xxxxxxxxxxxxxx>

> ---
>  mm/vmalloc.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index b7e314b..f63684a 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -2437,8 +2437,11 @@ static int vmalloc_open(struct inode *inode, struct file *file)
>        unsigned int *ptr = NULL;
>        int ret;
>
> -       if (NUMA_BUILD)
> +       if (NUMA_BUILD) {
>                ptr = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL);
> +               if (ptr == NULL)
> +                       return -ENOMEM;
> +       }
>        ret = seq_open(file, &vmalloc_op);
>        if (!ret) {
>                struct seq_file *m = file->private_data;
> --
> 1.7.0.4
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxxx  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/