Re: [PATCHv5 3/3] USB: gadget: storage_common: fixed warning buildingmass storage function

From: MichaÅ Nazarewicz
Date: Wed Jul 28 2010 - 09:00:39 EST

On Wed, 28 Jul 2010 14:25:59 +0200, Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:

On Wed, Jul 28, 2010 at 3:13 PM, Michal Nazarewicz
<m.nazarewicz@xxxxxxxxxxx> wrote:
The "nofua" attribute is used in the File-Storage Gadget but the
functions handling it are defined in storage_common.c (which may be
not a bad thing if anyone will want to port tho "nofua" attribute to
mass storage function) which causes the following warnings:

drivers/usb/gadget/storage_common.c:718: \
warning: âfsg_show_nofuaâ defined but not used
drivers/usb/gadget/storage_common.c:782: \
warning: âfsg_store_nofuaâ defined but not used

Adding __maybe_unused fixes this issue.
It's a bit odd.

Why the warning happens for those two only?
There are two more parameters (four methods) to handle 'ro' and 'file'
which are done in the same way.

Those are the only ones that are not used by the mass storage function.

The warning is issued when drivers using mass storage function are built.
File-Storage Gadget compiles fine.

Best regards, _ _
| Humble Liege of Serenely Enlightened Majesty of o' \,=./ `o
| Computer Science, MichaÅ "mina86" Nazarewicz (o o)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at