Re: [PATCHv5 3/3] USB: gadget: storage_common: fixed warning building mass storage function

[Andy Shevchenko]

On Wed, Jul 28, 2010 at 3:13 PM, Michal Nazarewicz
<m.nazarewicz@xxxxxxxxxxx> wrote:
> The "nofua" attribute is used in the File-Storage Gadget but the
> functions handling it are defined in storage_common.c (which may be
> not a bad thing if anyone will want to port tho "nofua" attribute to
> mass storage function) which causes the following warnings:
>
> drivers/usb/gadget/storage_common.c:718: \
> Âwarning: âfsg_show_nofuaâ defined but not used
> drivers/usb/gadget/storage_common.c:782: \
> Âwarning: âfsg_store_nofuaâ defined but not used
>
> Adding __maybe_unused fixes this issue.
It's a bit odd.

Why the warning happens for those two only?
There are two more parameters (four methods) to handle 'ro' and 'file'
which are done in the same way.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/