Re: [PATCH 05/10] x86, xsave: make xsave_cntxt_init() static

[Robert Richter]

On 20.07.10 18:20:24, Suresh Siddha wrote:

> Perhaps we can fold this patch into 
> [PATCH 06/10] x86, xsave: do not initialize xsave in fpu_init()
> 
> and probably do  fpu_init() first followed by xsave_init() so that
> fpu_init() will set xstate_size based on fpu features and xsave_init()
> can later overwrite xstate_size based on xstate features.

Yes, I will do this instead.

Lookin at this, I found that xsave is broken for (!HAVE_HWFP). This
should be the case if config MATH_EMULATION and 'no387' kernel
parameter are set and xsave exists. xsave will not work because
x86/math-emu and xsave share the same memory. But this case can be
treated as corner case. Maybe we should simply disable xsave then.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/