Re: [PATCH] KEYS: Reinstate lost passing of process keyring ID incall_sbin_request_key()

[James Morris]

On Wed, 30 Jun 2010, David Howells wrote:

> From: Justin P. Mattock <justinmattock@xxxxxxxxx>
> 
> In commit bb952bb98a7e479262c7eb25d5592545a3af147d there was the accidental
> deletion of a statement from call_sbin_request_key() to render the process
> keyring ID to a text string so that it can be passed to /sbin/request-key.
> 
> With gcc 4.6.0 this causes the following warning:
> 
>   CC      security/keys/request_key.o
> security/keys/request_key.c: In function 'call_sbin_request_key':
> security/keys/request_key.c:102:15: warning: variable 'prkey' set but not used
> 
> This patch reinstates that statement.
> 
> Without this statement, /sbin/request-key will get some random rubbish from the
> stack as that parameter.
> 
> Signed-off-by: Justin P. Mattock <justinmattock@xxxxxxxxx>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6#next


-- 
James Morris
<jmorris@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/