Re: [PATCH] docbook: need xmldoclinks for all doc types

From: Ben Hutchings
Date: Tue Jun 15 2010 - 20:46:46 EST


On Tue, 2010-06-15 at 08:36 -0700, Randy Dunlap wrote:
> On Tue, 15 Jun 2010 01:55:14 +0100 Ben Hutchings wrote:
>
> > Andy Whitcroft wrote:
> > > We need the xmldoclinks built for any document types built from the
> > > XML sources.
> >
> > Indeed we do. So make the XML files depend on xmldoclinks.
>
> The patch description tells me what but not why.

The quoted text from Andy says why.

> IOW, what error is this fixing and how do I produce that error
> when this patch is not applied?

$ rm -rf build
$ mkdir build
$ cp .config build
$ make O=build htmldocs
...
xmlto: /home/ben/src/linux-2.6/build/Documentation/DocBook/media.xml
does not validate (status 3)
xmlto: Fix document syntax or use --skip-validation option
/home/ben/src/linux-2.6/build/Documentation/DocBook/media.xml:4:
warning: failed to load external entity
"/home/ben/src/linux-2.6/build/Documentation/DocBook/media-entities.tmpl"
...

Ben.

--
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part