Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

From: Justin P. Mattock
Date: Tue Jun 15 2010 - 12:51:28 EST

On 06/15/2010 04:43 AM, Jean Delvare wrote:
Hi Justin,

On Mon, 14 Jun 2010 14:06:12 -0700, Justin P. Mattock wrote:
On 06/14/2010 01:53 PM, Jean Delvare wrote:
Hi Justin,

On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote:
could be a right solution, could be wrong
here is the warning:
CC drivers/i2c/i2c-core.o
drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':
drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used

Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>

drivers/i2c/i2c-core.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 1cca263..79c6c26 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -794,6 +794,8 @@ static int i2c_register_adapter(struct i2c_adapter *adap)
dummy = bus_for_each_drv(&i2c_bus_type, NULL, adap,
+ if(!dummy)
+ dummy = 0;

One word: scripts/

it was this, and/or just take the code out
(since I'm a newbie)

I was not (yet) arguing on the code itself, but on its format. Any
patch you send should pass the formatting tests performed by
scripts/ Thanks.

o.k. I'll make sure I run everything through before sending anything.

Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at