Re: [PATCH] pci: Don't enable aspm before drivers have had achance to veto it

From: Matthew Garrett
Date: Tue Jun 15 2010 - 11:33:10 EST

On Tue, Jun 15, 2010 at 05:29:02PM +0200, Tomas Henzl wrote:
> On 06/15/2010 05:18 PM, Matthew Garrett wrote:
> > On Tue, Jun 15, 2010 at 05:11:59PM +0200, Tomas Henzl wrote:
> >
> >
> >> Matthew, isn't it so that the POLICY_DEFAULT will pass the above test
> >> and possibly switch the ASPM on?
> >>
> > Yes. We assume that the BIOS authors aren't actively malicious.
> >
> I originally thought your patch is about not enabling ASPM on broken
> hardware (bios included) before the driver has a chance to change it.

Heh. No, if the BIOS set up ASPM on the controller, it seems like it's
safe to do the same. That's been the default behaviour of upstream for
some time now.

Matthew Garrett | mjg59@xxxxxxxxxxxxx
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at