Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unusedstatement warnings

From: Andi Kleen
Date: Tue Jun 15 2010 - 03:46:59 EST

On Tue, Jun 15, 2010 at 03:40:28AM -0400, Christoph Hellwig wrote:
> On Tue, Jun 15, 2010 at 09:02:45AM +0200, Andi Kleen wrote:
> > I suspect you miss quite a lot of valuable information from
> > your user base by not supporting On the other
> > hand it would likely also save you from spending time on
> > flakes.
> >
> > That said you don't need BUG_ON to support it (WARN etc. work
> > too), it's just the easiest way.
> Note that a XFS filesystem shutdown already gives a stack trace.
> But picking up every filesystem shutdown on seems
> to be quite a bit too much. It's usually due to IO errors from
> the underlying device.

Yes, but known race check asserts should be probably there, right?
Maybe you need a special kind of ASSERT (or shutdown) for those?


ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at