Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but notused

From: Justin P. Mattock
Date: Mon Jun 14 2010 - 23:56:47 EST

On 06/14/2010 08:49 PM, Valdis.Kletnieks@xxxxxx wrote:
On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said:

what I tried was this:

if (!rc)

and everything looked good,
but as a soon as I changed

rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE,
"attempting to determine the timeouts");

to this:

rc = transmit_cmd(chip,&tpm_cmd, TPM_INTERNAL_RESULT_SIZE);

if (!rc)
printk("attempting to determine the timeouts\n");

*baffled* Why did you think that would work? transmit_cmd()s signature
has 4 parameters.

I have no manual in front of me. Did a quick google, but came up with (no hits) info on what that function does. grep showed too many entries to really see why/what this is. So I kind of just scrambled with this one.

Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at