Re: [PATCH] ieee1394: sbp2: remove unused code

From: Justin P. Mattock
Date: Mon Jun 14 2010 - 21:59:29 EST

On 06/14/2010 05:05 PM, Stefan Richter wrote:
On 14 Jun, Justin P. Mattock wrote:
drivers/ieee1394/raw1394.c: In function 'arm_lock64':
drivers/ieee1394/raw1394.c:1373:11: warning: 'old' may be used
uninitialized in this function
drivers/ieee1394/raw1394.c: In function 'arm_lock':
drivers/ieee1394/raw1394.c:1155:12: warning: 'old' may be used
uninitialized in this function

Thanks. I briefly looked at this and am not sure if this is real or a
false positive. This code is old crud that is really hard to read.

I will look at it again at a more convenient time of day.

I dont think you need to buddy!! just applied all
patches you sent..
she looks like this now:

CC [M] drivers/firewire/core-card.o
CC [M] drivers/firewire/core-cdev.o
CC [M] drivers/firewire/core-device.o
CC [M] drivers/firewire/core-iso.o
CC [M] drivers/firewire/core-topology.o
CC [M] drivers/firewire/core-transaction.o
CC [M] drivers/firewire/ohci.o
CC [M] drivers/firewire/sbp2.o
LD [M] drivers/firewire/firewire-core.o
LD [M] drivers/firewire/firewire-ohci.o
LD [M] drivers/firewire/firewire-sbp2.o
CC drivers/firmware/dmi_scan.o
CC drivers/firmware/efivars.o
CC drivers/firmware/dmi-id.o
CC drivers/firmware/memmap.o
LD drivers/firmware/built-in.o

she's clean as a whistle!!

only concern now is the
hardware and driver functioning properly
i.g. I haven't installed the kernel
(if it even makes a difference)
just compiling and looking at warning messages.


Justin P. Mattock
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at