Re: [PATCH] soc/sh: Fix I2C dependency for SND_FSI_AK4642

From: Mark Brown
Date: Mon Jun 14 2010 - 12:10:43 EST


On Mon, Jun 14, 2010 at 05:39:41PM +0200, Peter Huewe wrote:

> bool "FSI-AK4642 sound support"
> depends on SND_SOC_SH4_FSI
> select SND_SOC_AK4642
> + select I2C

I'd have thought a depends was more appropriate. Arguably you want to
depend on the SH I2C driver since the driver is useless without the
relevant I2C controller.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/