Re: [PATCH 1/2] Remove preempt_enable/disable calls aroundsched_clock()

From: Ingo Molnar
Date: Sun Jun 13 2010 - 06:01:51 EST



* Divyesh Shah <dpshah@xxxxxxxxxx> wrote:

> On Sat, Jun 12, 2010 at 12:19 AM, Ingo Molnar <mingo@xxxxxxx> wrote:
> >
> > * Divyesh Shah <dpshah@xxxxxxxxxx> wrote:
> >
> >> calls in the block layer. This was a temporary fix added.
> >
> > Not good, this commit reintroduces those ugly warnings, if someone happens to
> > bisect straight into this commit.
>
> You're right. In the next version, I'll merge both patches into one so
> this cannot happen.

Yeah - or if you really want to make a point of doing the two things in two
separate patches you can first fix the API, _then_ remove the preemption
enable/disable.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/