Re: [PATCH] checkpatch.pl skip long lines

From: Wolfram Sang
Date: Sat Jun 12 2010 - 21:06:42 EST


On Sat, Jun 12, 2010 at 07:09:44PM +0200, Fredrik Gustafsson wrote:

> since the number of long lines in the linux kernel is huge and since
> Greg Kroah Hartman in his google tech talk about the kernel
> (http://www.youtube.com/watch?v=L2SED6sewRw) talked about probably
> ignore that criteria in the future, I thought the checkpatch.pl script
> should have an option to ignore checking for long lines.
>
> This would help finding the real errors and warnings, because they don't
> drown in line length warnings.

Instead of adding another command-line option, I'd suggest to just use CHK
instead of WARN, so this check will be enabled with --strict. I wonder if there
is already consensus on deprecating the 80-char-rule?

Regards,

Wolfram

--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |

Attachment: signature.asc
Description: Digital signature