Re: [PATCH 3/5] perf: Ability to enable in a paused mode

From: Peter Zijlstra
Date: Sat Jun 12 2010 - 05:44:52 EST

On Sat, 2010-06-12 at 09:34 +0200, Frederic Weisbecker wrote:
> struct pmu {
> int (*enable) (struct perf_event *event);
> + /*
> + * Reserve acts like enable, except the event must go in a "pause"
> + * state. Ie: it is scheduled but waiting to be started
> + * with the ->start() callback.
> + */
> + int (*reserve) (struct perf_event *event);
> void (*disable) (struct perf_event *event);

Urgh, so then we have, enable(), reserve() and start(), that's just too
much. Also, you need to visit all pmu implementations if you touch
struct pmu like that.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at