Re: [PATCH 5/6]kernel:module.c variable 'nowarn' set but not used

[Justin P. Mattock]

On 06/11/2010 02:17 PM, Geert Uytterhoeven wrote:
> On Fri, Jun 11, 2010 at 22:41, Justin P. Mattock
> <justinmattock@xxxxxxxxx>  wrote:
> > The below patch fixes a warning message
> > reported by gcc 4.6.0.
> >
> >   CC      kernel/module.o
> > kernel/module.c: In function 'add_usage_links':
> > kernel/module.c:1343:6: warning: variable 'nowarn' set but not used
> >
> >   Signed-off-by: Justin P. Mattock<justinmattock@xxxxxxxxx>
> >
> > ---
> >   kernel/module.c |    8 ++------
> >   1 files changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/kernel/module.c b/kernel/module.c
> > index 8c6b428..a71027a 100644
> > --- a/kernel/module.c
> > +++ b/kernel/module.c
> > @@ -1340,13 +1340,9 @@ static void add_usage_links(struct module *mod)
> >   {
> >   #ifdef CONFIG_MODULE_UNLOAD
> >         struct module_use *use;
> > -       int nowarn;
> > -
> > +
> >         mutex_lock(&module_mutex);
> > -       list_for_each_entry(use,&mod->target_list, target_list) {
> > -               nowarn = sysfs_create_link(use->target->holders_dir,
> > -&mod->mkobj.kobj, mod->name);
> > -       }
> > +       list_for_each_entry(use,&mod->target_list, target_list);
> >         mutex_unlock(&module_mutex);
> >   #endif
> >   }
>
> Also wrong, you removed the creation of the links in sysfs.

that's not good..

> The assignment to nowarn was there to avoid another compiler warning,
> as sysfs_create_link() is marked __must_check.
>
> Gr{oetje,eeting}s,
>
> 						Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds

alright.. thanks for having a look
and a response. if somebody has a fix
for this then let me know, and I can
test it out over here(I can also try
fixing this as well, but my knowledge
of code only goes so far)..

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/