Re: [PATCH] [16/23] XFS: Fix gcc 4.6 set but not read and unusedstatement warnings

From: Andi Kleen
Date: Fri Jun 11 2010 - 12:36:54 EST

On Fri, Jun 11, 2010 at 12:20:07PM -0400, Christoph Hellwig wrote:
> Most of this looks good to me, but I really don't like the QASSERT
> macro. If you're fine with it I'll split this up into smaller patches

Why do you not like it?

The alternative will be likely uglier.

> and resubmit the unmodified parts under your name and redo those bits
> I don't like.

Fine for me.

ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at