Re: [PATCH] drivers: regulator: add Maxim 8998 driver

From: Mark Brown
Date: Fri Jun 11 2010 - 09:00:36 EST


On Fri, Jun 11, 2010 at 09:48:58PM +0900, Kyungmin Park wrote:
> On Fri, Jun 11, 2010 at 7:58 PM, Mark Brown
> > On Fri, Jun 11, 2010 at 09:02:45AM +0200, Marek Szyprowski wrote:

> >> +static irqreturn_t max8998_ono_irq(int irq, void *data)
> >> +{
> >> + ? ? return IRQ_HANDLED;
> >> +}

> > This needs at least a comment explaining why you don't need to do
> > anything for the interrupt.

> We just remove it. it's unused function actually.

I suspect it may be required for the wake IRQ functionality you're using
but ICBW.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/