Re: [PATCH v4] ocfs2: Let ocfs2_setattr use new truncate sequence.

From: Tao Ma
Date: Fri Jun 11 2010 - 03:16:43 EST

Hi Christoph,

On 06/11/2010 02:56 PM, Christoph Hellwig wrote:
This looks correct, but still has the second if ATTR_SIZE block that
I commented on last time. I'd really prefer if the filesystems could
move the truncate handling into a single conditional to simplify
auditing for it and possibly splitting it out into a separate method
oh, that would be much work for ocfs2 to do from my perspective. So I would really want to leave it as-is and I have add it to my to-do list.

And btw, the S_ISREG check which you only have on the first ATTR_SIZE
check is superflous, the VFS only does ATTR_SIZE calls on regular files.
yeah, I can remove it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at