Re: [PATCH v2] panic: keep blinking in spite of long spin timer mode

From: TAMUKI Shoichi
Date: Thu Jun 10 2010 - 18:34:57 EST


On Wed, 9 Jun 2010 15:15:52 -0700 Andrew Morton wrote:

> Morse code? Kidding?

I'm sorry, I'm confusing you.

> Sorry, no. Nobody who uses this feature will know what what
> "words per minute" means. It's nutty!

That is just a strained interpretation where the measure of the
blinking speed comes from. The description of "words per minute"
has already disappeared in the latest patch.

> Please remind me why we're making this configurable at all. Can't we
> just hardwire the thing to 1Hz or something? Add an
> im_using_a_hypervisor boot option or something, if necessary?

For now, gta02_panic_blink(), one of panic_blink() users, expects a
10Hz call rate. IOW, it blinks at 5Hz (i.e. panicblink=36). I think
that the desirable blinking speed is different according to devices.

TAMUKI Shoichi
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at