Re: [PATCH 2/2 -next] niu: always include of_device.h

From: David Miller
Date: Wed Jun 09 2010 - 20:29:20 EST

From: Grant Likely <grant.likely@xxxxxxxxxxxx>
Date: Wed, 9 Jun 2010 17:45:54 -0600

> On Wed, Jun 9, 2010 at 4:44 PM, Randy Dunlap <randy.dunlap@xxxxxxxxxx> wrote:
>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>> The niu driver uses struct of_device when built on any arch, not
>> only SPARC64, so always #include <linux/of_device.h>.
>> drivers/net/niu.c:9700: warning: 'struct of_device' declared inside parameter list
>> drivers/net/niu.c:9700: warning: its scope is only this definition or declaration, which is probably not what you want
>> drivers/net/niu.c:9716: warning: assignment from incompatible pointer type
>> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
>> Cc:     Grant Likely <grant.likely@xxxxxxxxxxxx>
>> Cc:     Dave Miller <davem@xxxxxxxxxxxxx>
>> ---
>>  drivers/net/niu.c |    3 ---
> Looks okay to me (but I haven't build tested it yet). The bulk of
> of_device.h is compiled out when CONFIG_OF_DEVICE is not selected.
> David, are you okay with me taking this via my tree as it depends on
> Randy's other patch?

Yep, that's totally fine with me:

Acked-by: David S. Miller <davem@xxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at