Re: [PATCH] Fix a race in pid generation that causes pids to bereused immediately.

[Linus Torvalds]

On Wed, 9 Jun 2010, tytso@xxxxxxx wrote:
> 
> Well, I was thinking about something like this:

No, this is wrong for the case where you end up having to allocate a new 
pidmap and/or overflow max_pid.

It also doesn't set the bit at all.

> There appears to be some interesting uses of the bitmap by
> find_ge_pid() and next_pidmap() that I haven't completely grokked yet,

We need that bitmap to handle the overflow max_pid case. We are _not_ 
returning just increasing pid numbers.

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/