Re: Wrong DIF guard tag on ext2 write

From: Dave Chinner
Date: Tue Jun 08 2010 - 04:47:30 EST

On Tue, Jun 08, 2010 at 09:15:35AM +0200, Christof Schmitt wrote:
> On Mon, Jun 07, 2010 at 01:40:21PM -0400, Martin K. Petersen wrote:
> > >>>>> "Boaz" == Boaz Harrosh <bharrosh@xxxxxxxxxxx> writes:
> >
> > Boaz> Do you remember some performance numbers that show degradation /
> > Boaz> sameness?
> >
> > Boaz> What type of work loads?
> >
> > I haven't been using XFS much for over a year. I'm using an internal
> > async I/O tool and btrfs for most of my DIX/DIF testing these days.
> >
> > But my original changes were along the lines of what Jan mentioned
> > earlier (hooking into page_mkwrite and waiting for writeback. I could
> > have sworn that I only did it for ext[23] and that XFS waited out of the
> > box but git proves me wrong). Anyway, I'll try to get some benchmarking
> > happening later this week.
> Is there a patch with this change available somewhere? It might be
> useful to patch a kernel with this XFS change for reliable DIF/DIX
> testing.

Adding a wait_on_page_writeback() call to page_mkwrite() won't help
by itself - you need to unmap the pages after transitioning them
from dirty to writeback but before the hardware starts processing
the IO if you want to lock out mmap writes this way....


Dave Chinner
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at