Re: [PATCH] module: fix reference to mod->percpu after freeing module.

From: Tejun Heo
Date: Mon May 31 2010 - 06:25:32 EST


On 05/31/2010 12:23 PM, Rusty Russell wrote:
> Rafael sees a sometimes crash at precpu_modfree from kernel/module.c; it
> only occurred with another (since-reverted) patch, but that patch simply
> changed timing to uncover this bug, it was otherwise unrelated.
>
> The comment about the mod being freed is self-explanatory, but neither
> Tejun nor I read it. This bug was introduced in 259354deaa, after it
> had previously been fixed in 6e2b75740b. How embarrassing.
>
> Reported-by: "Rafael J. Wysocki" <rjw@xxxxxxx>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Cc: Tejun Heo <tj@xxxxxxxxxx>
> Cc: Masami Hiramatsu <mhiramat@xxxxxxxxxx>
> Tested-by: "Rafael J. Wysocki" <rjw@xxxxxxx>

Embarrassingly-Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks. :-)

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/