Re: [patch] complain when users abuse the pm_qos API

[Rafael J. Wysocki]

On Saturday 29 May 2010, mark gross wrote:
> The following patch is to help clean up API abusers of pm_qos where
> they call update_request before registering a request.
> 
> --mgross
> 
> --Signed-off-by: markgross <markgross@xxxxxxxxxxx>

Will there be a big issue if I push this during the next merge window?

Rafael


> From a0813007ddc7b72cb3da7a533fefba9889aab1d8 Mon Sep 17 00:00:00 2001
> From: mgross <mgross@mgross-desktop.(none)>
> Date: Fri, 28 May 2010 21:36:06 -0700
> Subject: [PATCH] complain when users abuse the pm_qos API by updating a request that
>  isn't registered yet.
> 
> ---
>  kernel/pm_qos_params.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/pm_qos_params.c b/kernel/pm_qos_params.c
> index f42d3f7..8e55bf1 100644
> --- a/kernel/pm_qos_params.c
> +++ b/kernel/pm_qos_params.c
> @@ -266,6 +266,10 @@ void pm_qos_update_request(struct pm_qos_request_list *pm_qos_req,
>  		spin_unlock_irqrestore(&pm_qos_lock, flags);
>  		if (pending_update)
>  			update_target(pm_qos_req->pm_qos_class);
> +	} else {
> +		WARN(true, "pm_qos: updating an unregistered request "
> +				"does nothing");
> +		dump_stack();
>  	}
>  }
>  EXPORT_SYMBOL_GPL(pm_qos_update_request);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/