Re: [Patch] fix packet loss and massive ping spikes with PPP multi-link

[Richard Hartmann]

==It seems LKML & netdev were dropped from the To list, re-adding==

Hi Walter,


> Âif (ppp->rrsched % ppp->n_channels == i)
>
> since both do not change in that while() loop you can calculate in advance
> perhaps ppp->rrsched %= ppp->n_channels before the while ?
> (that would reduce my bad feels about variables that only increments also :)

rrsched and i do change when appropriate. As they are used as a cheap
way to get round robin, rrsched is not even initialized. One can argue
that this should be done, but as it literally does not matter where the
value starts counting....


> btw: you are doing Âafter loop() if(pch->chan == NULL) continue;
> that means the else in the if below Âif (pch->chan) should never be reached.
> Or is it likely that some channel will be dropped (?) ?

Channels could be dropped and we need to guard against that.


> btw: this is intentional ? looks strange
>
> Â Â Â Âif(ppp_ml_noexplode) {
> + Â Â Â }
> + Â Â Â else {

Leftover from various printks for debugging reasons.


Thanks for your feedback,
Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/