Re: [PATCH 1/3] mm/swapfile.c: better messages for swap_info_get

From: Cesar Eduardo Barros
Date: Sat May 22 2010 - 14:19:12 EST

Em 22-05-2010 15:13, Borislav Petkov escreveu:
@@ -522,16 +522,16 @@ static struct swap_info_struct *swap_info_get(swp_entry_t entry)
return p;

- printk(KERN_ERR "swap_free: %s%08lx\n", Unused_offset, entry.val);
+ printk(KERN_ERR "swap_info_get: %s%08lx\n", Unused_offset, entry.val);

Why not let the compiler do it for ya:

printk(KERN_ERR "%s: %s%08lx\n", __func__, Unused_offset, entry.val);

?... etc.

See the third patch. This function becomes swap_info_get_unlocked(), and swap_info_get() becomes a small wrapper around it. Yet, I still want to keep printing swap_info_get: in the error message (whether it is locked or not makes no difference from the point of view of the error messsage).

Cesar Eduardo Barros
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at