Re: [PULL REQUEST] Ext2, ext3, and quota updates for 2.6.35-rc1

From: Dave Chinner
Date: Fri May 21 2010 - 20:06:05 EST

On Fri, May 21, 2010 at 09:24:56PM +0200, Jan Kara wrote:
> On Fri 21-05-10 11:50:15, Linus Torvalds wrote:
> >
> >
> > On Fri, 21 May 2010, Jan Kara wrote:
> > >
> > > Oops, I've just found a bug in one of my ocfs2 fixes. I've fixed that up
> > > so the new diffstat is here:
> >
> > I already pulled your previous version.
> OK, I'll push the fix separately.
> > And btw, Jan, I'm getting pretty upset with your apparently cavalier
> > attitude to filesystems. We've had several bugs lately for some quota or
> > filesystem "cleanups", which in at least one case caused corrupted
> > filesystems etc.
> That ext3 bug was nasty I agree :( I'm now pushing some quota tests to
> XFSQA and setup a machine that runs them. So that should improve a test
> coverage...

The other thing is that all the tests in xfstests can be run with
quota enabled to exercise the code rather than test for correctness.
This is done by running like:

# MOUNT_OPTIONS="-o usrquota,grpquota" ./check -g auto

And that makes all the tests run with user and group quotas enabled
for XFS. However, we might need a bit of help in the mount paths for
filesystems that require a quotaon command before they will run
all the generic tests with quotas enabled.


Dave Chinner
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at