Re: [PATCH v2] ptrace: unify FDPIC implementations

From: Roland McGrath
Date: Fri May 21 2010 - 14:35:41 EST

> This looks unsafe. What protect child->mm if ptrace() races with SIGKILL ?
> Of course, I do not blame this patch, the code was copied from arch/, but
> I think we need another patch which checks ->mm != NULL under task_lock()
> on top of this one?

Agreed, unless things are somehow different on nommu so there aren't such
races. But, as you mention, this is a long-standing issue that is entirely
unrelated to the cleanup here and should not delay merging this patch.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at