Re: [PATCH 02/10] rwsem: fully separate code pathes to wake writers vs readers

From: Michel Lespinasse
Date: Thu May 20 2010 - 17:48:27 EST


On Wed, May 19, 2010 at 5:04 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
> I hate code that jumps into braced blocks with goto.  Would it be possible for
> you to do:
>
>        readers_only:
>                if (downgrading)
>                        goto wake_readers;
>        ...
>        wake_readers:
>                /* Grant an infinite number of read locks to the readers at the front
>        ...
>
> instead, please?

Applied. Note that next patch in the series removes that code anyway :)

--
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/