Re: [PATCH 2/3] posix_timer: fix error path in timer_create

From: Andrew Morton
Date: Thu May 20 2010 - 15:33:10 EST

On Mon, 17 May 2010 21:18:07 +0400
Andrey Vagin <avagin@xxxxxxxxxx> wrote:

> move CLOCK_DISPATCH(which_clock, timer_create, (new_timer)) after all
> posible EFAULT erros.
> *_timer_create may allocate/get resources.
> (for example posix_cpu_timer_create does get_task_struct)

You've added a Cc:stable@xxxxxxxxxx to the mail headers, but there is
no "Cc: <stable@xxxxxxxxxx>" in the changelog. Please, if you think a
patch should go into -stable then add the tag to the changelog also -
this is more reliable and explicit than spraying things at a mailing

You cc'ed stable@xxxxxxxxxx on all three patches but IMO only [2/3]
(this patch) is needed in -stable.

And afaict, the bug which this patch fixes will allow a suitably-nasty
unprivileged application to leak an unbounded number of task-structs,
which is a box-killing local DoS. So yes, -stable wants this.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at