Re: [PATCH 05/10] rwsem: wake queued readers when writer blocks on active read lock

From: David Howells
Date: Wed May 19 2010 - 08:45:47 EST

Michel Lespinasse <walken@xxxxxxxxxx> wrote:

> + * Alternatively, if we're called from a failed down_write(), there
> + * were already threads queued before us, and there are no active
> + * writers, the lock must be read owned; so we try to wake any read
> + * locks that were queued ahead of us. */

The comma you've added after 'us' is wrong. That suggests that the implicit
'then' comes there. I take it you're a proponent of the Oxford/Harvard/serial

Apart from that miscellaneous grammatical difference, the patch is fine:-)

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at