Re: [PATCH v2] leds-lp3944: properly handle lp3944_configure failin lp3944_probe

[Antonio Ospite]

On Mon, 17 May 2010 17:47:48 +0800
Axel Lin <axel.lin@xxxxxxxxx> wrote:

> In current implementation, lp3944_probe return 0 even if lp3944_configure fail.
> Therefore, led_classdev_unregister will be executed twice
> ( in error handling of lp3944_configure and lp3944_remove ).
> This patch properly handles lp3944_configure fail in lp3944_probe.
> 
> Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>

Acked-by: Antonio Ospite <ospite@xxxxxxxxxxxxxxxxx>

Thanks.

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

Attachment: pgp00000.pgp
Description: PGP signature