Re: [PATCH] x86: CPU detection for RDC System-on-Chip

From: Alan Cox
Date: Sun May 16 2010 - 09:13:00 EST


> + case 0x00321004: /* tested */
> + strcpy(c->x86_model_id, "S3282/CodeTek");
> + break;
> + case 0x00321007:
> + strcpy(c->x86_model_id, "R8610");
> + break;
> + default:
> + pr_info("RDC CPU: Unrecognised Customer ID (0x%x) please "
> + "report to: linux-kernel@xxxxxxxxxxxxxxx\n",
> + customer_id);

Surely this should be a break as you want to set the vendor. You've
established its an RDC at this point have you not - so you want to set
x86_vendor.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/