Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

From: Len Brown
Date: Wed May 12 2010 - 01:27:31 EST



> #define IBFT_SIGN "iBFT"
...
> +#ifdef CONFIG_ACPI
> + /*
> + * One spec says "IBFT", the other says "iBFT". We have to check
> + * for both.
> + */

Really?
Which one do you see in the field?
any reason to #define "iBFT" above and not use it below?

> + if (!ibft_addr)
> + acpi_table_parse(ACPI_SIG_IBFT, acpi_find_ibft);
> + if (!ibft_addr)
> + acpi_table_parse("iBFT", acpi_find_ibft);
> +#endif /* CONFIG_ACPI */

Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/