Re: [PATCH 1/2] ibft: Update iBFT handling for v1.03 of the spec.

From: Konrad Rzeszutek Wilk
Date: Tue May 11 2010 - 14:55:33 EST


> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx>
> > Reviewed-by: Mike Christie <michaelc@xxxxxxxxxxx>
>
> This should have Peter's Signed-off-by:, please.
>
Done.
> > ...
> >
> > +#ifdef CONFIG_ACPI
> > +static int __init acpi_find_ibft(struct acpi_table_header *header)
> > +{
> > + ibft_addr = (struct acpi_table_ibft *)header;
>
> container_of() would be better here. And maybe elsewhere, too.

Actually there is no need for that. We are just casting it, not getting any
internal member.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/